Repository navigation
feat: glob support in the repo caveat matcher (adjoint/*) - #30
Merged
Merged
Conversation
Phase 2 of ADR 0008. RepoEq now matches via glob if the pattern contains '*' (owner/*, */repo, etc.); exact-match patterns are unchanged. No new Caveat variant, no macaroon format change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #22.
Summary
RepoEqnow matches via a minimal glob (*= any sequence) when the pattern contains*— e.g.repo = "adjoint/*"in a profile matches every repo under that owner*) are byte-for-byte unchangedCaveatvariant, no macaroon serialisation change — purely a semantics change to howRepoEqis checked, per ADR 0008 Phase 2globcrate)Test plan
cargo fmt && cargo clippy --all-targets -- -D warnings && cargo test --all— all pass (31 unit + 28 CLI integration)glob_match_cases,repo_eq_glob_matches_owner_prefix,repo_eq_exact_match_unchanged