Repository navigation
feat: profile inheritance via extends - #31
Merged
Merged
Conversation
Phase 2 of ADR 0008. A profile can extend a parent to inherit its secrets/env/ttl/caveats. Additive-only, mirroring the macaroon rule that a derived token can never widen its parent: - secrets may narrow to a subset, never widen - ttl may shorten, never lengthen - repo/branch/agent may only be added if the parent left them unset, never overridden - cycles and unknown parents rejected at load time
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #20.
Summary
extends = "parent"to inheritsecrets/env/ttl/repo/branch/agentfrom a parent profilesecretsmay narrow to a subset of the parent's, never widenttlmay shorten, never lengthenrepo/branch/agentmay only be set by the child if the parent left them unset — never overriddenenvis CLI sugar (not a caveat), so child entries simply merge on top of the parent'sCaveat, macaroon format, or existing (non-extends) profile behaviourTest plan
cargo fmt && cargo clippy --all-targets -- -D warnings && cargo test --all— all pass (31 unit + 28 CLI integration)profile::tests::file_system_load_paths: inherit-when-omitted, narrow secrets subset, reject-widen secrets, shorten ttl, reject-lengthen ttl, add unset caveat, reject-override-set caveat, unknown parent, inheritance cycle