Skip to content

Fix SpellArchive model lookup /errorspam#11

Merged
Aedial merged 1 commit into
Aedial:mainfrom
kaduvill:main
Mar 17, 2026
Merged

Fix SpellArchive model lookup /errorspam#11
Aedial merged 1 commit into
Aedial:mainfrom
kaduvill:main

Conversation

@kaduvill

@kaduvill kaduvill commented Mar 17, 2026

Copy link
Copy Markdown
Contributor

Fix SpellArchive variant lookup

This PR fixes SpellArchiveModelRetexture to use the canonical blockstate root for baked model lookup.

spell_archive is the only blockstate root for this block. The books value is a blockstate property, while spell_archive_1 through spell_archive_14 are model files under models/block/.

Before this change, the bake code used spell_archive_1, spell_archive_2, etc. as the ModelResourceLocation root, which caused invalid lookups:

18:15:23] [Client thread/DEBUG] [VintageFix]: Error loading model block definition
org.embeddedt.vintagefix.util.FastFileNotFoundException: spellarchives:blockstates/spell_archive_1.json
[18:15:23] [Client thread/ERROR] [org.embeddedt.vintagefix.dynamicresources.model.DynamicModelProvider]: Failed to load model spellarchives:spell_archive_1#books=1,facing=north
org.embeddedt.vintagefix.dynamicresources.model.DynamicModelProvider$DynamicModelLoadFailException: Variant spellarchives:spell_archive_1#books=1,facing=north does not exist
[18:15:23] [Client thread/ERROR] [org.embeddedt.vintagefix.dynamicresources.model.DynamicModelProvider]: Failed to load model spellarchives:spell_archive_1#books=1,facing=north as item spellarchives:spell_archive_1
org.embeddedt.vintagefix.dynamicresources.model.DynamicModelProvider$DynamicModelLoadFailException: Variant spellarchives:spell_archive_1#books=1,facing=north does not exist
[18:15:23] [Client thread/ERROR] [org.embeddedt.vintagefix.dynamicresources.model.DynamicBakedModelProvider]: Error occured while loading model spellarchives:spell_archive_1#books=1,facing=north
[18:15:23] [Client thread/ERROR] [org.embeddedt.vintagefix.dynamicresources.model.DynamicModelProvider]: Failed to load model spellarchives:spell_archive_1#books=1,facing=south
org.embeddedt.vintagefix.dynamicresources.model.DynamicModelProvider$DynamicModelLoadFailException: Variant spellarchives:spell_archive_1#books=1,facing=south does not exist
[18:15:23] [Client thread/ERROR] [org.embeddedt.vintagefix.dynamicresources.model.DynamicModelProvider]: Failed to load model spellarchives:spell_archive_1#books=1,facing=south as item spellarchives:spell_archive_1
org.embeddedt.vintagefix.dynamicresources.model.DynamicModelProvider$DynamicModelLoadFailException: Variant spellarchives:spell_archive_1#books=1,facing=south does not exist
[18:15:23] [Client thread/ERROR] [org.embeddedt.vintagefix.dynamicresources.model.DynamicBakedModelProvider]: Error occured while loading model spellarchives:spell_archive_1#books=1,facing=south
[18:15:23] [Client thread/ERROR] [org.embeddedt.vintagefix.dynamicresources.model.DynamicModelProvider]: Failed to load model spellarchives:spell_archive_1#books=1,facing=west
org.embeddedt.vintagefix.dynamicresources.model.DynamicModelProvider$DynamicModelLoadFailException: Variant spellarchives:spell_archive_1#books=1,facing=west does not exist
[18:15:23] [Client thread/ERROR] [org.embeddedt.vintagefix.dynamicresources.model.DynamicModelProvider]: Failed to load model spellarchives:spell_archive_1#books=1,facing=west as item spellarchives:spell_archive_1
org.embeddedt.vintagefix.dynamicresources.model.DynamicModelProvider$DynamicModelLoadFailException: Variant spellarchives:spell_archive_1#books=1,facing=west does not exist
[18:15:23] [Client thread/ERROR] [org.embeddedt.vintagefix.dynamicresources.model.DynamicBakedModelProvider]: Error occured while loading model spellarchives:spell_archive_1#books=1,facing=west
[18:15:23] [Client thread/ERROR] [VintageFix]: Suppressing further model loading errors for namespace 'spellarchives'
[18:15:23] [Client thread/DEBUG] [VintageFix]: Error loading model block definition
org.embeddedt.vintagefix.util.FastFileNotFoundException: spellarchives:blockstates/spell_archive_2.json
[18:15:23] [Client thread/DEBUG] [VintageFix]: Error loading model block definition
org.embeddedt.vintagefix.util.FastFileNotFoundException: spellarchives:blockstates/spell_archive_3.json
[18:15:23] [Client thread/DEBUG] [VintageFix]: Error loading model block definition
org.embeddedt.vintagefix.util.FastFileNotFoundException: spellarchives:blockstates/spell_archive_4.json
[18:15:23] [Client thread/DEBUG] [VintageFix]: Error loading model block definition
org.embeddedt.vintagefix.util.FastFileNotFoundException: spellarchives:blockstates/spell_archive_5.json
[18:15:23] [Client thread/DEBUG] [VintageFix]: Error loading model block definition
org.embeddedt.vintagefix.util.FastFileNotFoundException: spellarchives:blockstates/spell_archive_6.json
[18:15:23] [Client thread/DEBUG] [VintageFix]: Error loading model block definition
org.embeddedt.vintagefix.util.FastFileNotFoundException: spellarchives:blockstates/spell_archive_7.json
[18:15:23] [Client thread/DEBUG] [VintageFix]: Error loading model block definition
org.embeddedt.vintagefix.util.FastFileNotFoundException: spellarchives:blockstates/spell_archive_8.json
[18:15:23] [Client thread/DEBUG] [VintageFix]: Error loading model block definition
org.embeddedt.vintagefix.util.FastFileNotFoundException: spellarchives:blockstates/spell_archive_9.json
[18:15:23] [Client thread/DEBUG] [VintageFix]: Error loading model block definition
org.embeddedt.vintagefix.util.FastFileNotFoundException: spellarchives:blockstates/spell_archive_10.json
[18:15:23] [Client thread/DEBUG] [VintageFix]: Error loading model block definition
org.embeddedt.vintagefix.util.FastFileNotFoundException: spellarchives:blockstates/spell_archive_11.json
[18:15:23] [Client thread/DEBUG] [VintageFix]: Error loading model block definition
org.embeddedt.vintagefix.util.FastFileNotFoundException: spellarchives:blockstates/spell_archive_12.json
[18:15:23] [Client thread/DEBUG] [VintageFix]: Error loading model block definition
org.embeddedt.vintagefix.util.FastFileNotFoundException: spellarchives:blockstates/spell_archive_13.json
[18:15:23] [Client thread/DEBUG] [VintageFix]: Error loading model block definition
org.embeddedt.vintagefix.util.FastFileNotFoundException: spellarchives:blockstates/spell_archive_14.json
[18:15:24] [Client thread/DEBUG] [VintageFix]: Error loading model block definition

errors like: spell_archive_1#books=... lookups are gone and the archive variants render correctly in game.

@Aedial Aedial merged commit 1d81299 into Aedial:main Mar 17, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants