Fix SpellArchive model lookup /errorspam#11
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix SpellArchive variant lookup
This PR fixes
SpellArchiveModelRetextureto use the canonical blockstate root for baked model lookup.spell_archiveis the only blockstate root for this block. Thebooksvalue is a blockstate property, whilespell_archive_1throughspell_archive_14are model files undermodels/block/.Before this change, the bake code used
spell_archive_1,spell_archive_2, etc. as theModelResourceLocationroot, which caused invalid lookups:errors like:
spell_archive_1#books=...lookups are gone and the archive variants render correctly in game.