tsiclient graph right most label clipping 4015#49
Open
JimHui12 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This change simplifies x-axis behavior by making the configured D3 time scale the single source of truth for horizontal placement.
In TemporalXAxisComponent.ts, createOffsetXAxis() now uses this.x.copy() directly instead of re-reading chartOptions.timeFrame.
Why:
Previously, x-axis geometry could be influenced by both:
That created two possible authorities for tick placement. This change removes that duplication so the axis always follows the final runtime scale that the owning chart has already configured.
Impact:
Keeps tick generation aligned with the actual rendered chart domain
Makes x-axis behavior easier to reason about and debug
Preserves the current behavior for existing consumers that already set this.x.domain(...) before drawing the axis