Refactor: Replace 6 redundant tests with 2 parameterized tests#15
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #15 +/- ##
=======================================
Coverage 96.55% 96.55%
=======================================
Files 4 4
Lines 203 203
=======================================
Hits 196 196
Misses 7 7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hi @AyushAnand413 Thanks for the PR, per-commit hook is configured in the repo , you can install pre-commit in the repo after that it will automatically run from invocation of git commit, btw you should also run tox to verify things before pushing, please let me know if you need any help , you can search about these things on Internet. |
|
hey @Agent-Hellboy I've applied the pre-commit fixes and corrected line endings as discussed. All checks should pass now. Please review when convenient, and let me know if anything else is needed before merging. |
|
@Agent-Hellboy please respond!! |
|
Hi @AyushAnand413 i will check , I am busy with a regional festival. |
|
Yes please I have 1 pending out of 6 for hacktoberfest. |
Hi @Agent-Hellboy ,
I've manually reviewed the test suite and removed redundancy as requested in issue #13.
Here are my changes:
test_spew_config_default_valuesintotest_spew_config_initialization.test_basic_tracing..pyc/.pyofiles) into 2 cleaner, parameterized tests using@pytest.mark.parametrize.This makes the test suite much cleaner and easier to maintain. This refactor removes 6 redundant tests and replaces 4 of them with 2 new parameterized tests, bringing the total test count from 80 to 78.
All 78 remaining tests pass.
Closes #13