refactor(session): consolidate session and agent runtime loops - #688
Open
xiami762 wants to merge 31 commits into
Open
refactor(session): consolidate session and agent runtime loops#688xiami762 wants to merge 31 commits into
xiami762 wants to merge 31 commits into
Conversation
added 5 commits
August 7, 2026 15:24
Collect runtime prompt inputs before deterministic block assembly, preserve provider-specific cache boundaries, and keep context usage estimation aligned with execution. Prevent Bash tool errors from being rendered twice in the session UI.
added 10 commits
August 13, 2026 15:47
…-session-host # Conflicts: # flocks/session/session_loop.py # tests/session/test_prompt_tokens.py
…-session-host # Conflicts: # flocks/session/session_loop.py # tests/integration/test_real_tool_calls.py # tests/session/test_session_abort_inject.py
This reverts commit 62ca118.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SessionLoop,LoopContext,AgentLoop, andStepEnginewith explicit preparation, execution, continuation, and finalization boundaries.UserPromptSubmithooks./reviewcommand to use the selected primary agent instead of assuming an unavailableoracleagent.devbaseline (9d3810a3).Runtime architecture
Lifecycle hooks and continuation
session.startonce anduser.prompt.beforeonce per real logical user turn.turn.afteras an observational terminal hook. Hook output cannot create a synthetic continuation or override a goal that is waiting for user input.ContinuationPolicy, with abort and step-limit safeguards.llm.call.afterevent per logical model request and aggregate failed same-model retry attempts into its terminal payload.Model execution and cancellation safety
ModelRequestand reuse it for same-model retries, then release it when the assistant attempt finishes.Split scope
task/subtasktodelegate_task, permissions, TUI tool registry, API schema, generated SDK, workflows, and compatibility tests) remains isolated in refactor(delegation): migrate legacy task flows to delegate_task #716. This PR contains no task-to-delegate rewrites or delegation product-surface migration; its SessionLoop replacement only removes the retired private subtask execution branch together with the old loop.SessionRunnertoStepEngine; prompt builders, prompt composition, token accounting, and prompt-specific assertions are unchanged fromdev.devprompt APIs and registeredtaskcompatibility alias.Compatibility
SessionLoopremains the public entry point.Validation
devbaseline failures were explicitly deselected./reviewregression test passed in an isolated Flocks root.git diff --checkpassed.