fix: reject empty JSON-RPC batches - #5
Open
vsolano9 wants to merge 1 commit into
Open
Conversation
Return the required Invalid Request response before dispatch while preserving response-free notification batches.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4
What & why
JSON-RPC 2.0 requires an empty batch to produce one
Invalid Requestresponse object. Casebook instead fell through to its response-free batch path and returned HTTP 202.The guard now rejects
[]before dispatch with code-32600andid: null, matching the official batch specification. Non-empty notification-only batches remain response-free.Changes
202behaviorValidation
npm test— 14/14 passednpm run typecheck— passednpx wrangler deploy --dry-run— worker bundle succeeded, no deploymentThe repository defines no format or lint scripts;
git diff --checkpasses and the two changed files follow the existing style.Checklist
AI assistance: Codex helped implement and validate the patch; the final diff and test output were reviewed before submission.