fix: do not auto-resolve refunds with zero, negative, or non-finite amounts - #4
Open
Gabrielcafens wants to merge 2 commits into
Conversation
…mounts The refund policy auto-resolved any amount <= REFUND_AUTO_LIMIT, which included 0, negative numbers, and other invalid values that happened to satisfy the comparison. Now requires the amount to be finite and strictly greater than zero before auto-resolution; zero, negative, non-finite, and unstated amounts are escalated with a distinct reason each. Adds focused vitest tests for valid, zero, negative, non-finite, and unstated refund amounts. Fixes AgentPostmortem#3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3
The refund policy auto-resolved any amount
<= REFUND_AUTO_LIMIT, which included0, negative numbers, and other invalid values that happened to satisfy that comparison.lib/policy.test.ts(vitest) covering valid, zero, negative, non-finite, and unstated refund amounts — all 6 tests passtsc --noEmitpasses cleanAdded vitest as a devDependency since the repo had no test runner configured yet.