Reject invalid refund amounts before automatic action - #5
Open
vsolano9 wants to merge 1 commit into
Open
Conversation
Require refund amounts to be finite and greater than zero before automatic action. Escalate invalid values with a clear reason and cover valid, boundary, invalid, and missing-amount policy paths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
The refund guardrail currently auto-resolves zero and negative values, and treats non-finite values as ordinary over-limit refunds. This validates the amount before any automatic action so malformed triage output is routed to a human with a clear reason.
Closes #3
Changes
npm testwithout adding dependenciesValidation
npm test— 4/4 pass; repeated successfully 20 consecutive times<= 0to< 0) — fails the invalid-amount regression as expectednpx tsc --noEmit— passnpm run build— passopennextjs-cloudflare build— pass; bundle generated locally, no deploymentgit diff --check— passnpm ci— pre-existing failure: the committed lockfile no longer satisfies the ranged versions inpackage.jsonnpm run lint— pre-existing failure:next lintis no longer a supported Next.js commandChecklist