Skip to content

fix: reject non-positive search limit at the API boundary #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AshSgDe29071999 wants to merge 1 commit into from
Closed

fix: reject non-positive search limit at the API boundary #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/tenantq/search.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,8 @@ def search(
prefetch_limit: int = 50,
) -> List[SearchHit]:
"""Run a tenant-isolated search in the requested retrieval mode."""
if limit < 1:
raise ValueError(f"limit must be >= 1, got {limit!r}")
qfilter = build_filter(tenant_id, category, created_after, created_before)
params = models.SearchParams(hnsw_ef=settings.hnsw.hnsw_ef)

Expand Down
10 changes: 10 additions & 0 deletions tests/test_search.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,3 +38,13 @@ def test_created_at_range_filter(ingested, settings, embedder, dataset):
by_id = {d.id: d for d in dataset.documents}
for h in hits:
assert lo <= by_id[h.id].created_at <= hi


def test_search_rejects_non_positive_limit(ingested, settings, embedder):
import pytest
from tenantq.search import search

with pytest.raises(ValueError, match="limit must be >= 1"):
search(ingested, settings, embedder, "query", tenant_id="acme", limit=0)
with pytest.raises(ValueError, match="limit must be >= 1"):
search(ingested, settings, embedder, "query", tenant_id="acme", limit=-5)
Loading