Skip to content

fix: Reject empty/whitespace tenant_id in search filters #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
VedantMadane wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Reject empty/whitespace tenant_id in search filters #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/tenantq/search.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,12 @@ def build_filter(
created_before: Optional[int] = None,
) -> models.Filter:
"""Build a tenant-scoped filter, optionally narrowed by metadata."""
if tenant_id is None or not str(tenant_id).strip():
raise ValueError(
"tenant_id is required: request was not scoped to a tenant "
"(empty or whitespace-only tenant_id)"
)
tenant_id = str(tenant_id).strip()
must: List[models.FieldCondition] = [
models.FieldCondition(key=TENANT_FIELD, match=models.MatchValue(value=tenant_id))
]
Expand Down
15 changes: 15 additions & 0 deletions tests/test_search.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,3 +38,18 @@ def test_created_at_range_filter(ingested, settings, embedder, dataset):
by_id = {d.id: d for d in dataset.documents}
for h in hits:
assert lo <= by_id[h.id].created_at <= hi


import pytest
from tenantq.search import build_filter


@pytest.mark.parametrize("bad", ["", " ", "\t"])
def test_build_filter_rejects_empty_tenant_id(bad):
with pytest.raises(ValueError, match="not scoped"):
build_filter(bad)


def test_build_filter_accepts_tenant_with_internal_spaces():
f = build_filter("acme corp")
assert f.must
Loading