Reject invalid numeric CLI flags - #7
Open
vsolano9 wants to merge 1 commit into
Open
Conversation
Parse --max, --max-tool, and --price through one finite non-negative guard. Preserve zero budgets, fail with the exact flag and received value, and cover the real CLI process.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Bad numeric flags currently become
NaN, silently skip compaction, or print$NaNwhile exiting successfully. This makes all three numeric options fail clearly before payload processing while preserving a zero token budget.Closes #5
Changes
--max,--max-tool, and--pricenow share one finite non-negative parser.--max 0.Validation
--max 0passed.npm testpasses 12/12 and repeated successfully 20 consecutive times.npm pack --dry-runincludes only the intended five distributable files.git diff --checkpasses.npm auditis not applicable.Checklist
node --testpasses