refactor: remove legacy cloud sandbox IPC

[khaliqgant]

Summary

• Remove the orphaned BrokerManager.connectCloud() path that created an ad-hoc sandbox through Cloud's legacy /api/v1/sandboxes routes.
• Remove the matching broker:connect-cloud IPC handler, preload API, shared type, renderer mock, and obsolete test mock.
• Preserve the live attachCloudSandbox / connectCloudSandbox path used by CloudAgentManager.
• Keep src/main/cloud-agent.ts unchanged.

Companion Cloud work: AgentWorkforce/cloud#2894.

Verification

• src/main/broker.test.ts: 110 passed.
• src/main/ipc-handlers.test.ts: 26 passed.
• Final grep finds no connectCloud, broker:connect-cloud, or /api/v1/sandboxes references under src/.
• src/main/cloud-agent.ts is byte-unchanged.

Environment notes

The repository-wide TypeScript and Electron build commands remain blocked by pre-existing unrelated diagnostics and a relocated node_modules cache resolution issue. The affected broker/IPC suites were run directly; the IPC suite used Vite's symlink-preservation option so dependencies resolve from that existing cache.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: a3bb92ec-f738-41d2-9f95-c1469380fb44

📥 Commits

Reviewing files that changed from the base of the PR and between 504134e and 34f8d9f.

📒 Files selected for processing (6)

• src/main/broker.ts
• src/main/ipc-handlers.test.ts
• src/main/ipc-handlers.ts
• src/preload/index.ts
• src/renderer/src/lib/ipc-mock.ts
• src/shared/types/ipc.ts

💤 Files with no reviewable changes (5)

• src/main/ipc-handlers.ts
• src/shared/types/ipc.ts
• src/preload/index.ts
• src/renderer/src/lib/ipc-mock.ts
• src/main/ipc-handlers.test.ts

---

📝 Walkthrough

Walkthrough

The legacy connectCloud method and broker:connect-cloud IPC route were removed. Public IPC types, preload APIs, mocks, tests, and broker documentation now use the existing cloud sandbox attachment flow.

Changes

Cloud connection API cleanup

Layer / File(s)	Summary
Remove legacy cloud connection surface src/shared/types/ipc.ts, src/main/broker.ts, src/main/ipc-handlers.ts, src/main/ipc-handlers.test.ts, src/preload/index.ts, src/renderer/src/lib/ipc-mock.ts	Removed BrokerManager.connectCloud, the broker:connect-cloud handler, related preload and mock APIs, and the test fixture method. Updated broker documentation to remove the legacy path reference.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

• AgentWorkforce/pear#146: Both changes update the cloud-connection flow in src/main/broker.ts.

Suggested labels: no-agent-relay-review

Suggested reviewers: willwashburn, kjgbot

Poem

I nipped the old cloud path away,
And left sandbox attachment bright.
The broker sheds its unused route,
IPC now stays light.
A tidy burrow, clean and sound—
No legacy hops are found.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely describes removal of the legacy cloud sandbox IPC path.
Description check	✅ Passed	The description directly explains the removed legacy path, affected APIs, preserved flow, and verification results.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch feat/fleet-sandbox-node

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[cursor]

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

[cubic-dev-ai]

No issues found across 6 files

_{Re-trigger cubic}