-
Notifications
You must be signed in to change notification settings - Fork 60
fix(verify): stop feature verification reporting false green #1392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
0616906
fix(verify): stop feature verification reporting false green
72539f7
fix(verify): post Slack via relayflows integration, not a bot token
0f010e6
style: auto-format with Prettier
github-actions[bot] ec17d7e
fix(verify): correct defects found by a live end-to-end run
fcbfd7f
fix(cli): repair integration webhook create, document 16 hidden commands
1062989
fix(verify): address PR review feedback
724ff58
fix(cli): update remaining callers of the old webhook create signature
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
77 changes: 77 additions & 0 deletions
77
packages/cli/src/cli/commands/integration-webhook-create.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,77 @@ | ||
| import { Command } from 'commander'; | ||
| import { describe, expect, it, vi } from 'vitest'; | ||
|
|
||
| import { registerIntegrationCommands, type IntegrationCommandDependencies } from './integration.js'; | ||
|
|
||
| /** | ||
| * `relay integration webhook create` posts to `POST /v1/webhooks`, whose request | ||
| * schema is `{ channel, name? }` — the URL is part of the *response*. | ||
| * | ||
| * The command previously took a `<url>` argument and sent `{ url, event }`, so | ||
| * every invocation was rejected with "channel is required" and the required | ||
| * channel was never sent at all. A live verification run caught it. These tests | ||
| * pin the corrected contract so the argument order cannot silently regress. | ||
| */ | ||
| function makeProgram() { | ||
| const relay = { | ||
| integrations: { | ||
| webhooks: { | ||
| create: vi.fn(async (input: unknown) => ({ webhookId: 'wh_1', ...(input as object) })), | ||
| }, | ||
| }, | ||
| }; | ||
| const log = vi.fn(); | ||
| const error = vi.fn(); | ||
| const exit = vi.fn(); | ||
| const program = new Command(); | ||
| program.exitOverride(); | ||
| registerIntegrationCommands(program, { | ||
| createAgentRelay: () => relay as never, | ||
| resolveLocalRelayOptions: async () => ({ workspaceKey: 'rk_live_test' }), | ||
| isInteractive: () => false, | ||
| log, | ||
| error, | ||
| exit: exit as never, | ||
| } satisfies Partial<IntegrationCommandDependencies> as IntegrationCommandDependencies); | ||
| return { program, relay, log, error, exit }; | ||
| } | ||
|
|
||
| describe('integration webhook create', () => { | ||
| it('sends the channel the API requires', async () => { | ||
| const { program, relay } = makeProgram(); | ||
|
|
||
| await program.parseAsync(['integration', 'webhook', 'create', 'deploy-status'], { | ||
| from: 'user', | ||
| }); | ||
|
|
||
| expect(relay.integrations.webhooks.create).toHaveBeenCalledWith({ | ||
| channel: 'deploy-status', | ||
| name: undefined, | ||
| }); | ||
| }); | ||
|
|
||
| it('passes an optional name through', async () => { | ||
| const { program, relay } = makeProgram(); | ||
|
|
||
| await program.parseAsync( | ||
| ['integration', 'webhook', 'create', 'deploy-status', '--name', 'GitHub Alerts'], | ||
| { from: 'user' } | ||
| ); | ||
|
|
||
| expect(relay.integrations.webhooks.create).toHaveBeenCalledWith({ | ||
| channel: 'deploy-status', | ||
| name: 'GitHub Alerts', | ||
| }); | ||
| }); | ||
|
|
||
| it('never sends url or event, which the endpoint rejects', async () => { | ||
| const { program, relay } = makeProgram(); | ||
|
|
||
| await program.parseAsync(['integration', 'webhook', 'create', 'ops'], { from: 'user' }); | ||
|
|
||
| const payload = relay.integrations.webhooks.create.mock.calls[0]?.[0] as Record<string, unknown>; | ||
| expect(payload).toBeDefined(); | ||
| expect(payload).not.toHaveProperty('url'); | ||
| expect(payload).not.toHaveProperty('event'); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Use the standard
[Unreleased]heading.Unreleasedmust not embed a release type; reserve SemVer versions for released sections.Proposed fix
As per coding guidelines,
CHANGELOG.mdmust “maintain the correctly leveled[Unreleased]heading.”📝 Committable suggestion
🤖 Prompt for AI Agents
Source: Coding guidelines