Persist unreported fleet node load honestly - #307
Draft
kjgbot wants to merge 1 commit into
Draft
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
node.heartbeat.loadand constrain measured values to[0,1]load_reportedbit for nodes and providers via migration0034load: nullwhen a node-wide load is not fully measuredmax_agents: 0as unlimited across provider aggregatesWhy
Unbounded providers use
max_agents: 0. Existing heartbeats and persistence converted the undefined utilization ratio intoload: 0, so a node with 25 active agents appeared identical to one with 4 and consumers rendered both as confidently idle.loadnow has one definition: managed-agent capacity utilization (active_agents / max_agents), bounded to[0,1]. CPU, memory, queue depth, and dispatch latency are separate metrics. When no finite denominator exists—or any constituent provider is unmeasured—the aggregate load is explicitly unavailable.The migration also keeps old unbounded-provider
load: 0heartbeats unreported during a rolling upgrade, so legacy senders cannot revive the false idle state.Impact
GET /v1/nodesnow returnsload: nullwhen utilization is unavailable. SDK consumers must handle the nullable field. Finite-capacity nodes continue returning a numeric ratio.Companion Relay broker PR: AgentWorkforce/relay#1445
Validation
0034backfill exercised against finite, unbounded, mixed-provider, and direct-node fixturesXCTest