-
Notifications
You must be signed in to change notification settings - Fork 0
chore(self-host): pin the image to engine 8.0.0 to match hosted #320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,8 @@ | ||
| { | ||
| "name": "relaycast-self-host-image", | ||
| "private": true, | ||
| "version": "7.0.0", | ||
| "version": "8.0.0", | ||
| "dependencies": { | ||
| "@relaycast/engine": "7.0.0" | ||
| "@relaycast/engine": "8.0.0" | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This changes every newly built self-host image from engine 7.0.0 to 8.0.0, but the root changelog remains at an empty
[Unreleased]. Because this is the first pending user-visible change after the 8.0.0 release, add a concise entry and set the appropriate release-level heading so the upgrade is not omitted from the next release notes.AGENTS.md reference: AGENTS.md:L38-L40
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed in
9a4fd683, which landed after this thread was written (it is pinned to9a443afc).CHANGELOG.mdat the current head now carries, under## [Unreleased - Patch]→### Changed:That is the release-level heading and concise entry AGENTS.md:L38-L40 asks for, so the upgrade will not be omitted from the next release notes.
Worth noting the same commit fixed something more serious that this review round surfaced: the version bump had been done with
sed s/7.0.0/8.0.0/g, and127.0.0.1contains7.0.0as a substring — so the Compose port binding, the in-container healthcheck, the nginx and tunnel examples and four runbook commands had all been rewritten to128.0.0.1, which is not loopback. Caught independently here and by CodeRabbit. Verified fixed at head.