fix(windows): route background agent auth checks through aoprocess to suppress console window flashes#3006
Open
sriram687 wants to merge 1 commit into
Open
fix(windows): route background agent auth checks through aoprocess to suppress console window flashes#3006sriram687 wants to merge 1 commit into
fix(windows): route background agent auth checks through aoprocess to suppress console window flashes#3006sriram687 wants to merge 1 commit into
Conversation
… suppress console window flashes
Collaborator
|
Thanks for contributing to Agent Orchestrator. This PR is being picked up by the current external contributor on-call pair: If someone is already working on this, please continue as usual. For faster context or live questions, you can also join the AO Discord. Join the session here: Come by if you want to see what is being built, ask questions, or just hang around with the community. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses a Windows-specific user experience issue where brief command prompt window flashes would appear on the user's desktop whenever the local daemon ran background status/auth probes for registered agent CLIs.
Root Cause
Several agent adapters (specifically
authprobe.go,claudecode.go,codex.go,copilot/auth.go,kilocode/auth.go, andopencode.go) were calling the standard Go libraryexec.CommandContext(...)directly to probe status. On Windows, executing shell commands from a background/GUI application (like the AO daemon or the Electron wrapper) without specifying console window creation flags forces Windows to draw and temporarily flash a console window.Solution
We swapped direct standard library
exec.CommandContext(...)usage for the project's nativeaoprocess.CommandContext(...)helper (frombackend/internal/process). Theaoprocesspackage properly configures Windows execution flags (windows.CREATE_NO_WINDOWandHideWindow: true) to ensure all background child processes run completely invisibly.Changes
The following files were updated to import
aoprocessand callaoprocess.CommandContext(...)for background probes:backend/internal/adapters/agent/authprobe/authprobe.gobackend/internal/adapters/agent/claudecode/claudecode.gobackend/internal/adapters/agent/codex/codex.gobackend/internal/adapters/agent/copilot/auth.gobackend/internal/adapters/agent/kilocode/auth.gobackend/internal/adapters/agent/opencode/opencode.goVerification