feat(scm): fetch provider PR review body from GitHub#3010
Merged
illegalcall merged 1 commit intoJul 23, 2026
Conversation
Request the review `body` in the GitHub review-summary GraphQL selection and carry it through the SCM observation into the domain review rows, so the body column persisted in #3009 is actually populated. - add Body to ports.SCMReviewSummaryObservation - request body in the reviewSummaries GraphQL node and map it in scmReviewSummaryFromGraphQL - carry Body through domainFromObservation (observer) and claimRowsFromSCM (session claim path) Bounds are unchanged: still only the decisive submitted reviews capped by githubReviewSummaryLimit. Exposing the body through the session PR API is the next PR. Part of the reviews-tab revamp (#2433).
illegalcall
approved these changes
Jul 23, 2026
This was referenced Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Step 2 of the reviews-tab revamp (#2433): actually populate the
pr_reviews.bodycolumn added in #3009 by fetching the review summary text from GitHub.ports.SCMReviewSummaryObservationgainsBody.body, mapped inscmReviewSummaryFromGraphQL.Bodyflows throughdomainFromObservation(the observer refresh path) andclaimRowsFromSCM(the session claim path), so both persistence entry points carry it into the domain review rows written by the store.Bounds are unchanged: still only the decisive submitted reviews (
APPROVED/CHANGES_REQUESTED), capped bygithubReviewSummaryLimit(20).Stacked on #3009
Exposing the body through the session PR API / DTO / openapi is the next PR.
Tests
cd backend && go build ./... && go vet ./internal/adapters/scm/github/ ./internal/observe/scm/ ./internal/service/session/ ./internal/ports/cleango test ./internal/adapters/scm/github/ ./internal/observe/scm/ ./internal/service/session/ -count=1— provider test now asserts the query requestsbodyand maps it throughFetchReviewThreads