Fix/daemon failure toast#3017
Merged
Merged
Conversation
Move the banner out of the main column into a fixed top-right panel so it no longer pushes board/import content, and restyle it with the import-modal tokens.
Replace hardcoded toast width and details max-height with design tokens so the floating banner stays on the size scale.
codebanditssss
approved these changes
Jul 23, 2026
codebanditssss
left a comment
Collaborator
There was a problem hiding this comment.
correct and clean. moving the banner out of <main> to a fixed-position sibling makes it overlay instead of consuming layout height, which is the shift-the-board bug this fixes. the content restructure is logically equivalent, details still expand on toggle and role="alert" + buttons + code chip are preserved, and the existing DaemonFailureBanner.test.tsx (not in the diff) asserts on behavior rather than layout classes so it stays green and still covers the component.
verified a few things:
--space-6is defined (24px), so the new@utility w-daemon-failure-toastcalc(100vw - var(--space-6)) clamp is valid, and it mirrors the existing w-dialog-* pattern.- new tokens follow convention; the details max-h token (10rem) equals the old max-h-40.
- z-overlay is the standard overlay layer.
nits (non-blocking):
- reusing import-modal tokens (
--color-bg-import-modal,--color-text-import-title, etc.) for a daemon toast couples it to the import modal's theme. visually consistent, but semantically it borrows another component's tokens. wrap-break-wordis new here; the rest of the codebase usesbreak-words(both valid v4, same effect) so minor inconsistency.- top-right placement could overlap the topbar controls (bell / Kill / Orchestrator). your own test plan flags this, worth a glance at the after-screenshots, though those controls are effectively dead while the daemon is down.
pointer-events-autois redundant with no pointer-events-none parent, harmless.
approving.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DaemonFailureBannerout of<main>so it overlays the shell instead of consuming layout height.Test plan
Before
After