fix(workspace): prune stale registered worktrees on reuse#3028
Open
AllBeingsFuture wants to merge 1 commit into
Open
fix(workspace): prune stale registered worktrees on reuse#3028AllBeingsFuture wants to merge 1 commit into
AllBeingsFuture wants to merge 1 commit into
Conversation
When git still lists a worktree whose directory is missing or empty, prune the registration and treat it as absent so Create re-adds a real worktree instead of reusing a path that strands tmux in the server cwd.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Git can still list a worktree after its directory was deleted (stale registration).
existingWorktreetreated that path as reusable, so Create returned a missing path. Downstreamtmux new-session -cthen fell back to the tmux server cwd and stranded agents in the wrong directory.Solution
In
existingWorktree, if a registered path is missing or empty:ok=false) so Create re-adds a real worktreeTests
go test ./internal/adapters/workspace/gitworktree/ -count=1TestCreateReusesRegisteredWorktreeAtExpectedPathnow seeds the directory on disk (registered-but-missing paths are no longer reused).Notes
local/zh-ui-sync). Independent of any Chinese UI branch — no i18n or frontend changes.Independence
Can merge independently of the tmux stable-cwd and httpd forced-shutdown fixes.