Skip to content

fix(httpd): treat forced shutdown as a successful stop #3029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AllBeingsFuture wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(httpd): treat forced shutdown as a successful stop #3029

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions backend/internal/httpd/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,10 +131,16 @@ func (s *Server) Run(ctx context.Context) error {
defer cancel()

if err := s.http.Shutdown(shutdownCtx); err != nil {
// The deadline elapsed with connections still open; force them closed.
// The deadline elapsed with connections still open (long-lived SSE
// streams routinely outlive ShutdownTimeout). Force them closed.
// This is still a successful intentional stop: returning an error here
// makes the daemon process exit 1, which Electron reports as
// "daemon start failed" (code: exited) even though the user/app asked
// to stop.
s.log.Warn("graceful shutdown timed out, forcing close", "err", err)
_ = s.http.Close()
return fmt.Errorf("graceful shutdown exceeded %s: %w", s.cfg.ShutdownTimeout, err)
s.log.Info("daemon stopped after forced close")
return <-serveErr
}

s.log.Info("daemon stopped cleanly")
Expand Down