feat(renderer): pin orchestrator row in sidebar session tree#3032
Open
AllBeingsFuture wants to merge 2 commits into
Open
feat(renderer): pin orchestrator row in sidebar session tree#3032AllBeingsFuture wants to merge 2 commits into
AllBeingsFuture wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2804
Supersedes #2810 (same change, rebased onto current
mainafter merge conflicts). The original PR branch lives onAgentWrapper/agent-orchestratorand this worker could not force-push there (Permission denied to AllBeingsFuture), so the rebased tip is onAllBeingsFuture:ao/agent-orchestrator-24/sidebar-orchestrator-row.What
Shared helper / targeting fix
useOpenOrchestratorso both the topbar "Orchestrator" button and the new sidebar row route through the same recency-based picker (newestActiveOrchestrator).parentOrchestratorId) is not available in the Go rewrite domain yet, so this change does not attempt that backend fix.Rebase conflict resolution (
ShellTopbar.tsx)Main had grown past the PR base (new shell-terminal control, board spawn error UI, "Board" root crumb, richer open-orchestrator telemetry). Resolution kept those main behaviors and still routed open/spawn through
useOpenOrchestrator. The hook rethrows spawn failures so the board topbar can surfaceboardSpawnError.Tests
cd frontend && npm test -- --run src/renderer/components/Sidebar.test.tsx✅ (38 tests)Visual verification
ao previewis for previewing URLs in the desktop browser panel, not the app chrome, so it is not applicable for this sidebar UI change.