feat(reviews): two-section Reviews tab#3053
Open
codebanditssss wants to merge 2 commits into
Open
Conversation
codebanditssss
marked this pull request as ready for review
July 23, 2026 22:47
codebanditssss
requested review from
Pulkit7070,
Vaibhaav-Tiwari,
illegalcall and
neversettle17-101
July 23, 2026 22:52
Annieeeee11
reviewed
Jul 23, 2026
Split the Reviews tab into two sections: - Pull request reviews: GitHub review summaries (reviewer, verdict, submitted body) from the session PR summary API. - AO code reviews: the existing reviewer pane, relabeled. Each section renders one collapsible PR row per attached PR. Headers show PR identity and update context only; verdicts appear in the expanded rows, so there are no duplicate verdict pills. Both sections sit in the same bg-surface card the Summary and Files tabs use. The Pull request reviews section only appears when a PR has review summaries. All sizes/colors go through existing design tokens.
codebanditssss
force-pushed
the
feat/reviews-tab-two-section
branch
from
July 23, 2026 23:38
5f0612f to
4320c22
Compare
neversettle17-101
requested changes
Jul 24, 2026
neversettle17-101
left a comment
neversettle17-101
left a comment
Collaborator
There was a problem hiding this comment.
- The codex alignment is wrong. Can we add the codex icon instead of the existing icon WDYT?
- Can we make sure that we don’t see open terminal till the review has been run?
- Wdyt should the AO code review be on top or the other? Because we would run the AO code reviews and then raise it for review to others
- Also do you think we should show the dot beside changes requested or approved?
Address review feedback on the two-section Reviews tab: - show a codex mark for the AO reviewer harness instead of the generic shield (shield stays as the fallback for other harnesses) - keep the Open terminal button out of the footer until a review has run - link AO review rows to the posted GitHub review - lead with AO code reviews, PR reviews below - open up the AO panel spacing so rows are not stuck together - seed mock PR review entries so the section renders in preview
Collaborator
Author
hey, pushed the fixes to the reviews PR:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Splits the Reviews tab into two sections, per issue #2433:
Both render one collapsible PR row per PR. Headers show PR identity + update context only; verdicts live in the expanded rows (no duplicate pills). Sits in the same
bg-surfacecard as the Summary/Files tabs. All tokens, no hardcoded values.Backend (persist/fetch/expose the review body) already merged via #3009 / #3049 / #3046.