Allow standing owner approval for owner-initiated releases - #188
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Owner-initiated npm releases currently require a different reviewer even though the owner is the sole configured reviewer. The owner explicitly requested a standing exception for his own changes and releases.
Keep the sole-owner GitHub environment review gate, but permit owner approval without another reviewer. Add an approval helper that authenticates the owner by login and immutable ID, checks both original and rerun actors, main/release workflow, successful preparation and exact environment settings before approving staging. Other initiators retain separate owner review. Preserve historical Beta 8 limits and add a standing policy for future releases. Required CI, protected main, stage-only OIDC, byte review and npm 2FA remain intact.
Validation: 12 focused policy/identity/governance tests and public-surface audit. No runtime package bytes change.