fix(acp): round-trip permission_mode + derive permissionModes from VARIANTS#198
Merged
Merged
Conversation
panel.rs translate dropped PermissionModeChanged (fell through _ => None), so AgentsMesh's permission selector showed '—' until a manual switch. Add the arm mirroring ModelChanged/ThinkingChanged → emit _loopal/permission_mode; loopal runtime already emits PermissionModeChanged on cold-start + switch. Also derive the permissionModes capability list from PermissionMode::VARIANTS (strum::VariantNames) instead of a hardcoded array, making the enum the single source of truth.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
AgentsMesh's permission selector showed "—" (unknown) for loopal pods until a
manual switch — loopal's current/initial permission_mode never reached the frontend.
Root cause:
translate/panel.rsdroppedPermissionModeChanged(fell through_ => None), unlikeModelChanged/ThinkingChangedwhich emit_loopal/model/_loopal/thinking.Fix
panel.rs: addPermissionModeChangedarm → emit_loopal/permission_mode.loopal runtime already emits this on cold-start (
cold_start_emit.rs) + switch(
input_control_config.rs), so cold-start now seeds the selector's current mode.permission.rs: derivestrum::VariantNames(serialize_all snake_case);lifecycle.rsadvertisespermissionModesfromPermissionMode::VARIANTSinstead of a hardcoded array — the enum is now the single source of truth.
AgentsMesh side (separate change)
runner
handler.gomaps_loopal/permission_mode→ OnConfigChange → configChanged→
acpSession.configuration.permissionMode, so the selector renders the current mode.Test
bazel test //crates/loopal-acp/... //crates/loopal-tool-api/...+ clippy + rustfmt green.