[16.0][IMP] purchase_request_approval_disbursement: auto-done purchase request on approval#681
Open
madara1150 wants to merge 1 commit into16.0from
Open
Conversation
…est on approval Auto-set purchase.request state to done based on use_purchase_order flag: - When use_purchase_order=False: set done immediately upon approval - When use_purchase_order=True: set done after PO is created via approval_make_purchase_order
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
use_purchase_order = Falseและpurchase.request.approvalเลื่อนสถานะเป็นapprovedจะปรับpurchase.requestเป็นdoneทันทีuse_purchase_order = Trueจะปรับpurchase.requestเป็นdoneหลังจากสร้าง Purchase Order ผ่านapproval_make_purchase_orderแล้วเท่านั้นChanges
button_approved()เพื่อเรียกrequest_id.button_done()เมื่อไม่ใช้ POapproval_make_purchase_order()เพื่อเรียกrequest_id.button_done()หลังสร้าง POTest plan
use_purchase_order = False: approve PA → ตรวจสอบว่า purchase.request state = doneuse_purchase_order = True: approve PA → ตรวจสอบว่า state ยังไม่เป็น done → กดสร้าง PO → ตรวจสอบว่า state = done