Skip to content

Feature/remove external icons#766

Closed
Dami24-hub wants to merge 3 commits into
Agora-Events:mainfrom
Dami24-hub:feature/remove-external-icons
Closed

Feature/remove external icons#766
Dami24-hub wants to merge 3 commits into
Agora-Events:mainfrom
Dami24-hub:feature/remove-external-icons

Conversation

@Dami24-hub
Copy link
Copy Markdown
Contributor

@Dami24-hub Dami24-hub commented May 30, 2026

Description

This PR significantly optimizes the application's bundle size by completely removing all external heavy asset dependencies (such as lucide-react and fontawesome). All icon implementations across the application layers have been successfully migrated to locally served, highly compressed static SVGs housed within the public/icons/ asset wrapper.

This drastically cuts down on client-side JS evaluation time and improves initial page-load performance scores.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance Optimization / Refactoring (non-breaking asset cleanup)

Implementation Details

  • Dependency Deprecation: Excised unused icon library packages from package.json and cleaned up global node modules.
  • Static Asset Migration: Gathered and organized clean vector files into public/icons/ matching the project design specs.
  • Component Refactoring: Rewrote presentation logic to favor native static paths or clean, custom-inlined components handling scalable path attributes.

How Has This Been Tested? / Visual Preview

  • Local Deployment Check: Launched the application locally to inspect elements across global components.
  • Visual Verification: Verified icon rendering consistency against Figma by testing the changes directly on the local dev server at:
  • Production Compilation: Executed npm run build ensuring bundle chunk generation passes smoothly with zero broken references.
  • Lint & Format Validation: Verified that npm run lint returns green with zero warnings.

Checklist:

  • My branch is named conventionally (refactor/issue-712-remove-external-icons)
  • Absolutely no external icon module import strings remain in the codebase
  • All icon elements have responsive styling and adjust accurately across standard viewports
  • Changes pass all remote GitHub CI automation hooks
    Fixes FRONTEND: Remove External Icon Libraries (Lucide, FontAwesome) #712

@vercel
Copy link
Copy Markdown

vercel Bot commented May 30, 2026

@Dami24-hub is attempting to deploy a commit to the oseh-svg's projects Team on Vercel.

A member of the Team first needs to authorize it.

@drips-wave
Copy link
Copy Markdown

drips-wave Bot commented May 30, 2026

@Dami24-hub Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@Dami24-hub Dami24-hub closed this Jun 1, 2026
@Dami24-hub Dami24-hub reopened this Jun 1, 2026
@Dami24-hub Dami24-hub closed this Jun 1, 2026
@Dami24-hub Dami24-hub deleted the feature/remove-external-icons branch June 1, 2026 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FRONTEND: Remove External Icon Libraries (Lucide, FontAwesome)

1 participant