Feature/remove external icons#766
Closed
Dami24-hub wants to merge 3 commits into
Closed
Conversation
|
@Dami24-hub is attempting to deploy a commit to the oseh-svg's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@Dami24-hub Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR significantly optimizes the application's bundle size by completely removing all external heavy asset dependencies (such as
lucide-reactandfontawesome). All icon implementations across the application layers have been successfully migrated to locally served, highly compressed static SVGs housed within thepublic/icons/asset wrapper.This drastically cuts down on client-side JS evaluation time and improves initial page-load performance scores.
Type of Change
Implementation Details
package.jsonand cleaned up global node modules.public/icons/matching the project design specs.How Has This Been Tested? / Visual Preview
npm run buildensuring bundle chunk generation passes smoothly with zero broken references.npm run lintreturns green with zero warnings.Checklist:
refactor/issue-712-remove-external-icons)Fixes FRONTEND: Remove External Icon Libraries (Lucide, FontAwesome) #712