Refactor/issue 712 remove external icons#808
Merged
OSEH-svg merged 5 commits intoJun 1, 2026
Merged
Conversation
…ucide-react - Rewrite components/ui/icons.tsx to use <img> tags pointing to /icons/*.svg (fixes no-restricted-syntax ESLint rule banning inline <svg> elements) - Add 8 missing SVG assets: chevron-down, chevron-up, close, minus, plus, gift, check-circle, external-link - Regenerate pnpm-lock.yaml without lucide-react (removed from package.json in prior commit) Closes Agora-Events#712
Prevents build crash in CI and local environments without a database. The sitemap's try/catch already handles missing data gracefully.
|
@Dami24-hub is attempting to deploy a commit to the oseh-svg's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR significantly optimizes the application's bundle size by completely removing all external heavy asset dependencies (such as
lucide-reactandfontawesome). All icon implementations across the application layers have been successfully migrated to locally served, highly compressed static SVGs housed within thepublic/icons/asset wrapper.This drastically cuts down on client-side JS evaluation time and improves initial page-load performance scores.
Type of Change
Implementation Details
package.jsonand cleaned up global node modules.public/icons/matching the project design specs.How Has This Been Tested? / Visual Preview
Local Deployment Check: Launched the application locally to inspect elements across global components.
Visual Verification: Verified icon rendering consistency against Figma by testing the changes directly on the local dev server at:
Production Compilation: Executed
npm run buildensuring bundle chunk generation passes smoothly with zero broken references.Lint & Format Validation: Verified that
npm run lintreturns green with zero warnings.Checklist:
refactor/issue-712-remove-external-icons)Fixes #712