Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Russian to the Windows JavaFX client and BLE bridge, and fix the shortcut editor and Save interaction. Studio includes 312 resource keys plus 368 legacy display translations; the bridge embeds 47 English/Russian/Chinese resource keys. Studio passes the selected language to the bridge; standalone startup reads the shared preference and then Windows UI language, with English fallback.
Deleting a shortcut's base key previously threw from the model setter because empty/modifier-only intermediate states were rejected. Rebuilding then restored the old key. Drafts now retain those intermediate states, both left/right modifiers remain visible, and Clear removes all keys. Save validates complete active shortcuts; runtime never substitutes Win+H for an incomplete draft. F18 remains reserved.
Save previously probed device capabilities on the JavaFX thread even for desktop-only K1 actions. K1-only edits now persist locally while disconnected; device preflight runs in the background transaction before writes. Capability gates, ACK checks and dirty-snapshot semantics remain intact. BLE window opacity is now 100%, and secondary toolbar groups wrap without horizontal scrolling. New messages are in all three translation catalogs.
build-local-windows.ps1creates a Russian-default portable EXE/ZIP and optional WiX installer using a supplied JavaFX runtime and built bridge. The local package is unsigned and excludes speech models/native speech assets, firmware and WCHISP. The formal release pipeline is unchanged; JDK installer auxiliary messages retain English fallback. Low-level vendor logs and remaining firmware exception strings are outside this localization pass.Validation:
mvn -f ahakeyconfig-win-java/pom.xml package— 312 tests passed, release contents OK.Local saving does not provide missing firmware support. The existing physical F18 and device-write requirements remain; no firmware was flashed. The central canvas retains its existing scrolling; this is a bounded toolbar improvement.
Integration with #66: both changes touch the cache log in
TcpServer.OnBleNotify. Keep this PR's localized log and #66's removal of the early return so physical status is broadcast. The combined result is tested locally; this PR remains based oneternal-devwithout bundling the transport or WCHISP fixes.Exact commands, root causes and validation limits:
docs/windows-shortcut-save-fix.md,docs/windows-stabilization-plan.md, andBLE_tcp_bridge/readme.md. No binaries, private settings, raw logs or proprietary tools are included.Installer upgrade correction: local replacement builds can specify
-PackageVersionindependently from the source JAR version. The initial rebuilt 1.5.3 MSI reused its ProductCode and returned Windows Installer 1638. The replacement 1.5.4 EXE was installed over the existing 1.5.3 successfully (exit 0), preserving user draft/language preference hashes; installed JAR/bridge hashes match the build, and Studio starts with a responsive window. The read-onlyTest-LocalInstallerUpgrade.ps1passes for 1.5.3 -> 1.5.4 and rejects the old package against itself. Fourth-component versions are rejected because MSI ignores that component for upgrades.Conflict resolution against eternal-dev a878f63: retained upstream verified-USB preference, real AhaType/account behavior and prepared WCHISP workflow, together with Russian UI and shortcut/save fixes. Maintenance completion messages preserve the upstream distinction between writing firmware and reading its version. Full Maven package passed 354 tests; MSBuild Release, BLE localization and the actual JavaFX shortcut/save smoke test passed. No firmware or installed application changes.