feat: add en.hennoveltranslations - #655
Open
antil-samarth wants to merge 12 commits into
Open
Conversation
Author
|
I did use ai for this. LMK if needs rework or any changes ! |
kkantan
requested changes
Jul 30, 2026
Co-authored-by: kantan <31490942+kkantan@users.noreply.github.com>
…uery filtering Move chapter number, metadata extraction, and content rating functions to a dedicated helper module. Add case-insensitive search filtering on the novel list and remove unsupported tag search configuration.
…u-sources into hennoveltranslations
…agraph and get_page_list functions
kkantan
requested changes
Jul 31, 2026
Co-authored-by: kantan <31490942+kkantan@users.noreply.github.com>
…u-sources into hennoveltranslations
kkantan
requested changes
Aug 1, 2026
kkantan
left a comment
kkantan
left a comment
Contributor
There was a problem hiding this comment.
why does https://hennoveltranslations.com/archives/novels/the-genius-martial-artist-who-remembers-everything not load any chapters in the source, despite free chapters being available on the website?
| let genre_str = helper::extract_meta_value(&meta_text, "Genre:"); | ||
| if !genre_str.is_empty() { | ||
| let tags: Vec<String> = genre_str | ||
| .split(',') |
Contributor
There was a problem hiding this comment.
i think it should also be split by whitespace, and empty sections should be removed. the meta value extraction also doesn't seem entirely accurate, since it's appending the "light novel status" to the tags.
| .and_then(|el| el.text()) | ||
| .unwrap_or_default(); | ||
|
|
||
| manga.status = match helper::extract_meta_value(&meta_text, "Status:").as_str() { |
Contributor
There was a problem hiding this comment.
this doesn't appear to work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added Hennoveltranslations source for light novels.
https://hennoveltranslations.com/
Does get status, author, genre, type, viewer from novel page.
The site also has patreon integration for advance chapter paywall. Haven't touched that part as don't have access to actually test if code would work.