feat: add es.latazamediollena - #656
Conversation
kkantan
left a comment
kkantan
left a comment
There was a problem hiding this comment.
the build.sh and build.ps1 scripts should no longer be required, these were for before the aidoku-rs cli existed.
| "id": "es.eslatazamediollena", | ||
| "name": "La Taza Medio Llena", | ||
| "version": 1, | ||
| "url": "https://www.latazamediollena.es/", |
There was a problem hiding this comment.
| "url": "https://www.latazamediollena.es/", | |
| "url": "https://www.latazamediollena.es", |
| @@ -0,0 +1,13 @@ | |||
| { | |||
| "info": { | |||
| "id": "es.eslatazamediollena", | |||
There was a problem hiding this comment.
the language code doesn't need to be prefixed twice.
| "id": "es.eslatazamediollena", | |
| "id": "es.latazamediollena", |
| key: slug.clone(), | ||
| title: Some(title_from_slug(&slug)), |
There was a problem hiding this comment.
if you define the title in a variable before the struct initialization, you don't need to clone the slug.
| if page > 1 { | ||
| return Ok(MangaPageResult { | ||
| entries: Vec::new(), | ||
| has_next_page: false, | ||
| }); | ||
| } |
There was a problem hiding this comment.
this won't be called with page > 1.
|
|
||
| let manga = comic_info(); | ||
| let matches = match query { | ||
| Some(query) if !query.is_empty() => { |
There was a problem hiding this comment.
the query won't be empty
| Some(query) if !query.is_empty() => { | |
| Some(query) => { |
| impl ListingProvider for Latazamediollena { | ||
| fn get_manga_list(&self, _listing: Listing, page: i32) -> Result<MangaPageResult> { | ||
| self.get_search_manga_list(None, page, Vec::new()) | ||
| } | ||
| } |
There was a problem hiding this comment.
this doesn't need to be implemented.
|
|
||
| [dev-dependencies] | ||
| aidoku = { git = "https://github.com/Aidoku/aidoku-rs.git", features = ["test"] } | ||
| aidoku-test = { git = "https://github.com/Aidoku/aidoku-rs.git" } No newline at end of file |
There was a problem hiding this comment.
| aidoku-test = { git = "https://github.com/Aidoku/aidoku-rs.git" } | |
| aidoku-test = { git = "https://github.com/Aidoku/aidoku-rs.git" } | |
| @@ -0,0 +1,23 @@ | |||
| [package] | |||
| name = "la-taza-medio-llena" | |||
There was a problem hiding this comment.
| name = "la-taza-medio-llena" | |
| name = "latazamediollena" |
There was a problem hiding this comment.
and chance this could be made a bit higher quality, and the padding increased on the sides?
Removed unused build scripts Changed Cargo.toml with new name and new line at the end Changed URL in source.json Removed unused functions in lib.rs Avoid cloning on helper.rs
|
changed to draft until all fixes are done |
|
Back to ready, all proposals have been implemented. I could not improved the quality of the icon but I have added a little bit of padding. |
2 participants
Adding support for La Taza Medio Llena, a Spanish webcomic. https://www.latazamediollena.es/
As it is a single webcomic, only one comic is available and chapters are the pages of the webcomic, much like XKCD.
There's no cover for the comic yet, but a physical version is in development, so the plugin will be updated whenever we have a proper image.
Disclosure: I used AI to help me develop this plugin.