fix(ru.desu): migrate to new API and web login - #659
Conversation
The legacy /manga/api endpoint returns api_deprecated. Switch manga to /api/manga, add XenForo login for ranobe HTML catalog, and keep domain configurable via settings.
7f98981 to
e8d6eab
Compare
kkantan
left a comment
kkantan
left a comment
There was a problem hiding this comment.
the desu source changes look good, but you should split the added remanga source into a separate pr.
| } else { | ||
| params.push(&id, Some(&v.join(","))) | ||
| genres.extend(values); | ||
| } else if !values.is_empty() { |
There was a problem hiding this comment.
I don't think it's possible for a multi-select filter to be sent with no included or excluded values, so this check is probably useless.
| Ok(pages) | ||
| .collect()), | ||
| Section::Ranobe => { | ||
| let url = chapter.url.clone().unwrap_or_else(|| { |
There was a problem hiding this comment.
does this need to be cloned?
|
|
||
| Ok(Some(DeepLinkResult::Manga { | ||
| key: manga_id.to_string(), | ||
| key: format!("m:{manga_id}"), |
There was a problem hiding this comment.
since you're changing ids, you should mark this source version as a breaking change and implement the id migration trait if possible.
There was a problem hiding this comment.
It is backward compatible, so it works correctly.
ok, as for the other changes, I based them on the fact that the source material also includes ranobe. |
Switch auth to WebView XenForo cookies and show account status. Add MigrationHandler for the m: manga id prefix, mark breakingChangeVersion 5, and apply small review notes.
e8d6eab to
1f381e3
Compare
remmody
changed the title
|
Split Remanga into a separate PR: #664 Also addressed the review notes on this PR:
|
2 participants
Summary
/api/mangaAPI and add ranobe section supportm:{id}Test plan
m:keys