feat: add ja.mangarawbest - #661
Merged
Merged
Conversation
kkantan
requested changes
Aug 2, 2026
kkantan
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #16
Summary
Implementation notes
/search?q=...silently ignores the query — it always returns the unfiltered catalogue. The actual search endpoint isfilter[name]=.../filter[artist]=...on/manga-list, reverse-engineered from the site's ownapp.js.filter[doujinshi]=...(the third "search type" option in the site's own UI) never returns any results regardless of value, so it was left out offilters.jsonrather than shipping a filter option that silently returns nothing./genre/...URLs but prefixes every label with the series title (e.g.<title> Action). Tags are scraped from a selector scoped to the info block only, and there's a test asserting no tag contains the series title, so a regression here fails loudly instead of silently reintroducing junk tags.第N話, which the app already renders fromchapter_number. Keeping the scraped title as well would show it twice in the reader (e.g. "41話 - 41話"), so titles that are just第<number>話are dropped.6日前,2週間前, etc.) — there's no absolute date anywhere in the markup, so they're converted fromcurrent_date().filter[status]=1. Status is parsed from that query value first, falling back to the label text only if the link is missing.content_ratingis inferred from genre tags (成人向け/hentai-family tags → NSFW,Ecchi/Mature/etc. → Suggestive, otherwise Safe), since the source itself is registered ascontains-nsfw.Test plan
cargo test— 19 tests, all hitting the live site (no mocked HTML), covering: browse pagination (including the single-page/no-results case where the pagination bar is absent), all 3 listings, search hits, filter combinations actually narrowing results (asserted against the unfiltered baseline, not just "doesn't error"), series details, chapter list ordering/format, page list, and deep link parsing (includingwww./ query-string / trailing-slash variants)cargo fmt --check— cleancargo clippy— no warningsaidoku package+aidoku verify— schema validation passes forsource.json,filters.json,settings.json, and the icon (128×128, fully opaque)aidoku serveand read a chapter in the iOS appChecklist
cargo fmthas been run before submissioncargo clippyoutputs no lint warningsstatus/content_ratingare set on series when availableDeepLinkHandleris implemented for both series and chapter URLs