Request - #390
Merged
Merged
Conversation
|
@Qoder-Undefined Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SorobanEscrowProvider` lacks tests and documentation
Area: Backend
Description: soroban-escrow.provider.ts bridges the NestJS backend to the on-chain escrow contract but has no spec file and no JSDoc explaining the integration. Add unit tests mocking the Stellar SDK calls and document the expected environment variables.
File(s): backend/src/payments/providers/soroban-escrow.provider.ts, backend/src/payments/providers/soroban-escrow.provider.spec.ts
Priority: Medium
Implementation & verification: Trace all controller, service, provider, and module-registration callers before changing the implementation so the DTO and HTTP-error contract remains stable. Add focused automated coverage for the reported failure mode and the expected successful path, mocking external services where applicable.
Work distribution: Implementation: backend/src/payments/providers/soroban-escrow.provider.ts. Integration: update the closest controller, module, DTO, or caller only if the service contract changes. Verification: backend/src/payments/providers/soroban-escrow.provider.spec.ts.
closes #209
closes #210
closes #212
closes #211