security: validate download paths to prevent path traversal#87
Open
manearobert3 wants to merge 1 commit into
Open
security: validate download paths to prevent path traversal#87manearobert3 wants to merge 1 commit into
manearobert3 wants to merge 1 commit into
Conversation
Filenames received from the GitHub API were used to construct local file paths without checking that the resolved path stays inside the intended directory. A compromised upstream repository could supply a filename like '../../evil.exe' to write arbitrary files on the user's machine. Apply the existing is_safe_path() helper (already used in safe_extract.py) in both skin_downloader.py and repo_downloader.py before any file is written.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Filenames received from the GitHub API were used to construct local file paths without checking that the resolved path stays inside the intended directory. A compromised upstream repository could supply a filename like '../../evil.exe' to write arbitrary files on the user's machine.
Apply the existing is_safe_path() helper (already used in safe_extract.py) in both skin_downloader.py and repo_downloader.py before any file is written.