Clear historic entry when default skin is played#94
Open
Kneju wants to merge 2 commits into
Open
Conversation
When a champion is played on the default skin, the historic entry was never cleared from historic.json, causing the custom skin popup to reappear on the next champion select even though the user's last choice was the default skin. Extended the default skin check from ui_skin_id == 0 to is_default_skin(ui_skin_id) to catch the actual base skin ID (champion_id * 1000), and call clear_historic_entry() so the file reflects the user's last real choice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a champion is played on the default skin, the historic entry was
never cleared from historic.json, causing the custom skin popup to
reappear on the next champion select even though the user's last
choice was the default skin.
Extended the default skin check from ui_skin_id == 0 to
is_default_skin(ui_skin_id) to catch the actual base skin ID
(champion_id * 1000), and call clear_historic_entry() so the file
reflects the user's last real choice.