Skip to content

Update promicro_pretty.js for Ergogen 4.x#2

Open
PedroTheIntern wants to merge 1 commit intoAlbert-IV:mainfrom
PedroTheIntern:patch-1
Open

Update promicro_pretty.js for Ergogen 4.x#2
PedroTheIntern wants to merge 1 commit intoAlbert-IV:mainfrom
PedroTheIntern:patch-1

Conversation

@PedroTheIntern
Copy link

No description provided.

@infused-kim
Copy link

Thank you! This PR solved my problem of this footprint not working in ergogen v4.

To make this more findable in google, I was getting this error:

Scaffolding PCBs...
TypeError: Cannot read properties of undefined (reading 'GND')
    at Object.body (eval at exports.unpack (/opt/homebrew/lib/node_modules/ergogen/src/io.js:26:24), <anonymous>:169:19)
    at /opt/homebrew/lib/node_modules/ergogen/src/pcbs.js:274:15
    at exports.parse (/opt/homebrew/lib/node_modules/ergogen/src/pcbs.js:337:33)
    at Object.process (/opt/homebrew/lib/node_modules/ergogen/src/ergogen.js:82:27)
    at /opt/homebrew/lib/node_modules/ergogen/src/cli.js:127:29
make: *** [ergogen] Error 3

@Albert-IV perhaps the repo could adopt a new structure of having ergogen_v3/ and ergogen_v4/ directories at the root to make it easier for users?

@Albert-IV
Copy link
Owner

Honestly we can probably update the libraries we have in here to be v4 compliant. I think there's a way of packaging modules to extend Ergogen built into the API now, maybe it would be best to have this repo only concern itself with packaging nice community modules rather than patching modules into the Ergogen node_modules files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants