fix(apk-ux): modernize BaseSegmentedControl haptic feedback and touch targets#1233
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
Generated by: .github/nightly-prompts/12-apk-ux.md
Reasoning:
[UX Issue]: The
BaseSegmentedControlcomponent used manual, programmatic haptics inside theselectOptionhandler and did not comply with 48px touch target guidelines for the compact variant, resulting in potential tactile response duplication and reduced touch accuracy in Android WebViews.[Impact]: Reduced touch accuracy on high-density mobile displays and duplicate haptics upon double-triggering inside Android WebView.
Changes:
useHapticswith the declarativev-tactiledirective, removing the pointerdown-blocking.hit-targetclass from buttons, and establishing relative absolute::afterpseudo-element selectors for 48px hit area coverage. Splitted template to conditionally applyv-tactiledirective only to inactive buttons, avoiding redundant haptics.v-tactiledirective, and trigger both pointer and click events to assert declarative haptic brokering.Verification:
pnpm run build), and dependency graph layer validation (depcruise) completed successfully with zero regressions or violations.Log Updates:
.github/nightly-logs/12-apk-ux-coverage.log.github/nightly-logs/00-pr-history.mdPR created automatically by Jules for task 2300299466326894910 started by @AlbiDR