Skip to content

fix(apk-ux): modernize BaseSegmentedControl haptic feedback and touch targets#1233

Merged
github-actions[bot] merged 1 commit into
Nightlyfrom
nightly/stage-12-apk-ux-9a4f7e2d-2300299466326894910
Jul 26, 2026
Merged

fix(apk-ux): modernize BaseSegmentedControl haptic feedback and touch targets#1233
github-actions[bot] merged 1 commit into
Nightlyfrom
nightly/stage-12-apk-ux-9a4f7e2d-2300299466326894910

Conversation

@google-labs-jules

Copy link
Copy Markdown
Contributor

Generated by: .github/nightly-prompts/12-apk-ux.md

Reasoning:

[UX Issue]: The BaseSegmentedControl component used manual, programmatic haptics inside the selectOption handler and did not comply with 48px touch target guidelines for the compact variant, resulting in potential tactile response duplication and reduced touch accuracy in Android WebViews.
[Impact]: Reduced touch accuracy on high-density mobile displays and duplicate haptics upon double-triggering inside Android WebView.

Changes:

  • [BaseSegmentedControl.vue]: Modernized by replacing manual, programmatic useHaptics with the declarative v-tactile directive, removing the pointerdown-blocking .hit-target class from buttons, and establishing relative absolute ::after pseudo-element selectors for 48px hit area coverage. Splitted template to conditionally apply v-tactile directive only to inactive buttons, avoiding redundant haptics.
  • [BaseSegmentedControl.spec.ts]: Synchronized unit tests to register global v-tactile directive, and trigger both pointer and click events to assert declarative haptic brokering.

Verification:

  • [Automated]: Full monorepo Vitest suite (1426 passed), PWA client production compilation (pnpm run build), and dependency graph layer validation (depcruise) completed successfully with zero regressions or violations.

Log Updates:

  • Updated .github/nightly-logs/12-apk-ux-coverage.log
  • Updated .github/nightly-logs/00-pr-history.md

PR created automatically by Jules for task 2300299466326894910 started by @AlbiDR

@google-labs-jules

Copy link
Copy Markdown
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@supabase

supabase Bot commented Jul 26, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project hucktamloykszinwbtuh because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@github-actions
github-actions Bot merged commit 757e1e0 into Nightly Jul 26, 2026
2 of 3 checks passed
@github-actions
github-actions Bot deleted the nightly/stage-12-apk-ux-9a4f7e2d-2300299466326894910 branch July 26, 2026 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants