Remove runtime DB initialization; require explicit Alembic migrations - #44
Merged
AlexKitipov merged 1 commit intoJun 9, 2026
Merged
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 00be28c283
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
init_dbimport and thelifespanhook inapp/main.py, so the app no longer callscreate_allon startup.scripts/migrate.shwhich runsalembic upgrade headand copied thescripts/directory into the Docker image viaDockerfileso migrations can be run from the image.migrateservice todocker-compose.yml(profilemigrations) that runs the migration helper as a separate step, and removed the implicitalembic upgrade headfrom the backend startup command.deploy.shandREADME.mdto ensure.envis created before migrations and to run migrations explicitly (./scripts/migrate.sh/alembic upgrade head) before enabling/starting the service or bringing up the API.Testing
python -m pytestand all tests passed (8 passed).git diff --checkwhich reported no issues.sh -n scripts/migrate.sh deploy.shwhich succeeded without syntax errors.docker compose configvalidation but it could not be run in this environment because Docker is not installed.Codex Task