Tibo#1
Conversation
olga-arkhipenko
left a comment
olga-arkhipenko
left a comment
There was a problem hiding this comment.
Do more commits. Read about margins and paddings, seems to me, u don't understand the difference.
Restructuring styles folders required.
| <link rel="stylesheet" type="text/css" href="./styles/send-message-form.css"> | ||
| <link rel="stylesheet" type="text/css" href="./styles/footer.css"> | ||
| <link rel="stylesheet" type="text/css" href="./styles for icons/fontawesome-all.css"> | ||
| <link rel="stylesheet" type="text/css" href="./styles for layout/reset.css"> |
There was a problem hiding this comment.
styles for layout? Do u have any other styles in this project?
It's not an appropriate folder name.
| <link rel="stylesheet" type="text/css" href="./styles/team.css"> | ||
| <link rel="stylesheet" type="text/css" href="./styles/send-message-form.css"> | ||
| <link rel="stylesheet" type="text/css" href="./styles/footer.css"> | ||
| <link rel="stylesheet" type="text/css" href="./styles for icons/fontawesome-all.css"> |
There was a problem hiding this comment.
U already have a "styles for layout" folder, what do u think about merging them?
| <li class="navigation__button"><a href="#">work</a></li> | ||
| <li class="navigation__button"><a href="#">about</a></li> | ||
| <li class="navigation__button"><a href="#">home</a></li> | ||
| <li class="navigation__item"><a href="#">contact</a></li> |
There was a problem hiding this comment.
Split it into separate lines - each tag on the next line, it will be more readable.
There was a problem hiding this comment.
Class name should no describe what element looks like.
Read here
| <div class="news__do-you-like-rabbits-text">DO YOU LIKE RABBITS?</div> | ||
| <div class="news__do-you-like-oranges-text">DO YOU LIKE ORANGES?</div> | ||
| <section class="advertising"> | ||
| <div class="advertising__first-transparent-text">DO YOU LIKE RABBITS?</div> |
| <div class="news__do-you-like-oranges-text">DO YOU LIKE ORANGES?</div> | ||
| <section class="advertising"> | ||
| <div class="advertising__first-transparent-text">DO YOU LIKE RABBITS?</div> | ||
| <div class="advertising__second-transparent-text">DO YOU LIKE ORANGES?</div> |
There was a problem hiding this comment.
Class name should no describe what element looks like.
|
|
||
| grid-template-columns: 33.333% 33.333% 33.333%; | ||
| grid-template-rows: 33.333% 33.333% 33.333%; | ||
| } |
There was a problem hiding this comment.
All you need is to center it according the whole page, and then center every of the animals according its box.
| @@ -1,14 +1,24 @@ | |||
| body { | |||
| body | |||
There was a problem hiding this comment.
That is not reset.css.
Please just use normal reset.css, don't write it yourself.
| body { | ||
| body | ||
| { | ||
| max-width: 1400px; |
| @@ -1,14 +1,24 @@ | |||
| body { | |||
| body | |||
There was a problem hiding this comment.
And yes, it should not be in the same folder with blocks.
| @@ -0,0 +1,76 @@ | |||
| .send-message | |||
| { | |||
| max-width: 1200px; | |||
There was a problem hiding this comment.
The problem with this max-width (why not width?) is that: if it changes u'll need to change it in every block.
2 participants
No description provided.