Skip to content

fix: encode payment path identifiers #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ElaineWorkspaceEcosystem wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: encode payment path identifiers #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions src/ovoid/services/payment.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,11 @@ class PaymentService:
def __init__(self, client: OVOClient) -> None:
self._client = client

@staticmethod
def _path_segment(value: str) -> str:
"""Encode an identifier before inserting it into a URL path."""
return quote(value, safe="")

def do_qr_payment(
self,
body_request: dict[str, Any],
Expand Down Expand Up @@ -67,15 +72,17 @@ def get_payment_method(self) -> dict[str, Any]:

def get_payment_method_by_merchant(self, merchant_id: str) -> dict[str, Any]:
"""``GET wallet/payment-method/merchant/{id}``."""
return self._client.get(self._PATH_PAYMENT_METHOD_MERCHANT + merchant_id)
return self._client.get(self._PATH_PAYMENT_METHOD_MERCHANT + self._path_segment(merchant_id))

def get_payment_method_by_merchant_deal(self, merchant_id: str, deal_id: str) -> dict[str, Any]:
"""``GET wallet/payment-method/merchant/{id}/deals/{deal_id}``."""
return self._client.get(self._PATH_PAYMENT_METHOD_MERCHANT + merchant_id + "/deals/" + deal_id)
merchant = self._path_segment(merchant_id)
deal = self._path_segment(deal_id)
return self._client.get(self._PATH_PAYMENT_METHOD_MERCHANT + merchant + "/deals/" + deal)

def get_remaining_timeout(self, order_id: str) -> dict[str, Any]:
"""Remaining order time (``GET wallet/order/{orderID}/expiry``)."""
return self._client.get(self._PATH_ORDER_EXPIRY + order_id + "/expiry")
return self._client.get(self._PATH_ORDER_EXPIRY + self._path_segment(order_id) + "/expiry")

def get_tip(self, client_id: str, request: dict[str, Any]) -> dict[str, Any]:
"""Suggested tip (``POST v1.0/reference/master/amounts`` with ``clientId`` header)."""
Expand Down
Loading