Dev#228
Merged
Merged
Conversation
…tdown Introduce shared.WaitOrKill() that escalates gracefully: wait for natural exit after stdin close → SIGTERM → SIGKILL, each with a 10s grace period. Replace all direct Kill()+Wait() calls across claude_stream_driver, jsonrpc_line_client, and opencode_appserver_driver. Also fix a nil-Process bug in jsonrpc_line_client.Close() that would call cmd.Wait() on a never-started command. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
resetServerForNextRequest was holding d.mu while calling WaitOrKill which can block up to 20s. Release the lock before waiting so new requests are not blocked. Change SubprocessGracePeriod/SubprocessTermGracePeriod from const to var for testability, and add unit tests covering normal exit, non-zero exit, already-exited, SIGTERM escalation, and SIGTERM acceptance. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
make checkpasses locallybook/(bothen/andzh/if applicable)Related Issues