test: add test patterns for noder and parser#35
Merged
Conversation
Lemon73-Computing
added
good first issue
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors unit tests in Noder.cs and Parser.cs by converting them to theory-based tests using MemberData for better parameterization. The review feedback identifies several improvement opportunities, specifically regarding cross-platform compatibility issues caused by hardcoded line endings (\r\n) in expected outputs. Additionally, the feedback points out a typo in a comment and suggests removing or properly handling commented-out test cases to maintain code cleanliness.
Code CoverageResult: success Show coverage summarySummary
Risk HotspotsNo risk hotspots found. Coverage
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.