Skip to content

Conversation

@davidrohr
Copy link
Collaborator

@mconcas : Not sure what we want to do for std::cout << SMatrixGPU()-like cases. Either we hide them in the code, or we implement them, or we just make them output nothing like I did here.
Btw, I saw that the mRep of SMatrixGPU member is public. Is there a reason?

@davidrohr davidrohr requested a review from shahor02 as a code owner November 11, 2024 13:14
@github-actions
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1

@mconcas
Copy link
Collaborator

mconcas commented Nov 11, 2024

@mconcas : Not sure what we want to do for std::cout << SMatrixGPU()-like cases. Either we hide them in the code, or we implement them, or we just make them output nothing like I did here. Btw, I saw that the mRep of SMatrixGPU member is public. Is there a reason?

I won't take care of adding features we don't need now.
So I'm okay with a no-op, until we'll need some actual implementation.
Concerning the publicity of mRep, this is inherited straight from ROOT fRep datamember, I have no further nuances about it.

https://github.com/root-project/root/blob/b2da3719ab52f7e4cf22e7a2545e3d8a24d99726/math/smatrix/inc/Math/SMatrix.h#L683

@alibuild
Copy link
Collaborator

alibuild commented Nov 11, 2024

Error while checking build/O2/fullCI for 21925aa at 2024-11-11 21:21:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
/sw/SOURCES/O2/13678-slc8_x86-64/0/DataFormats/Reconstruction/src/TrackParametrizationWithError.cxx(807): error: calling a __host__ function("T1 & o2::math_utils::detail::operator <<< ::o2::gpu::detail::DummyLogger> (T1 &, const  ::o2::math_utils::detail::SMatrixGPU<double, (unsigned int)5u, (unsigned int)5u,  ::o2::math_utils::detail::MatRepSymGPU<double, (unsigned int)5u> >  &)") from a __device__ function("o2::track::TrackParametrizationWithError<float> ::getPredictedChi2 const") is not allowed
/sw/SOURCES/O2/13678-slc8_x86-64/0/DataFormats/Reconstruction/src/TrackParametrizationWithError.cxx(807): error: identifier "o2::math_utils::detail::operator <<< ::o2::gpu::detail::DummyLogger> " is undefined in device code
/sw/SOURCES/O2/13678-slc8_x86-64/0/DataFormats/Reconstruction/src/TrackParametrizationWithError.cxx(899): error: calling a __host__ function("T1 & o2::math_utils::detail::operator <<< ::o2::gpu::detail::DummyLogger> (T1 &, const  ::o2::math_utils::detail::SMatrixGPU<double, (unsigned int)5u, (unsigned int)5u,  ::o2::math_utils::detail::MatRepSymGPU<double, (unsigned int)5u> >  &)") from a __device__ function("o2::track::TrackParametrizationWithError<float> ::update") is not allowed
/sw/SOURCES/O2/13678-slc8_x86-64/0/DataFormats/Reconstruction/src/TrackParametrizationWithError.cxx(899): error: identifier "o2::math_utils::detail::operator <<< ::o2::gpu::detail::DummyLogger> " is undefined in device code
ninja: build stopped: subcommand failed.

Full log here.

@alibuild
Copy link
Collaborator

Error while checking build/O2/fullCI for ded948d at 2024-11-13 10:27:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
/sw/SOURCES/O2/13678-slc8_x86-64/0/Common/MathUtils/include/MathUtils/SMatrixGPU.h:520:3: error: a type specifier is required for all declarations
/sw/SOURCES/O2/13678-slc8_x86-64/0/Common/MathUtils/include/MathUtils/SMatrixGPU.h:520:59: error: expected ';' at end of declaration
/sw/SOURCES/O2/13678-slc8_x86-64/0/Common/MathUtils/include/MathUtils/SMatrixGPU.h:521:8: error: unknown type name 'X'
/sw/SOURCES/O2/13678-slc8_x86-64/0/Common/MathUtils/include/MathUtils/SMatrixGPU.h:521:22: error: unknown type name 'Y'
/sw/SOURCES/O2/13678-slc8_x86-64/0/Common/MathUtils/include/MathUtils/SMatrixGPU.h:521:45: error: use of undeclared identifier 'T'
ninja: build stopped: subcommand failed.

Full log here.

@alibuild
Copy link
Collaborator

Error while checking build/O2/fullCI for 6c81c31 at 2024-11-14 00:18:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
/sw/BUILD/aa5e002bb88100d32878c344cfb1958d2ffd6e37/O2/Detectors/ITSMFT/ITS/tracking/GPU/hip/TrackingKernels.hip:845:47: error: use nullptr [modernize-use-nullptr]
/sw/BUILD/aa5e002bb88100d32878c344cfb1958d2ffd6e37/O2/Detectors/ITSMFT/ITS/tracking/GPU/hip/TrackingKernels.hip:852:47: error: use nullptr [modernize-use-nullptr]
/sw/BUILD/aa5e002bb88100d32878c344cfb1958d2ffd6e37/O2/Detectors/ITSMFT/ITS/tracking/GPU/hip/TrackingKernels.hip:937:47: error: use nullptr [modernize-use-nullptr]
/sw/BUILD/aa5e002bb88100d32878c344cfb1958d2ffd6e37/O2/Detectors/ITSMFT/ITS/tracking/GPU/hip/TrackingKernels.hip:944:47: error: use nullptr [modernize-use-nullptr]
++ [[ 0 == 0 ]]
++ exit 1
--

Full log here.

@davidrohr davidrohr merged commit 1901f38 into AliceO2Group:dev Nov 14, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants