Skip to content

Conversation

@miranov25
Copy link
Contributor

@miranov25 miranov25 commented Dec 12, 2024

Fixes #8901

@github-actions github-actions bot changed the title Fix the bug -PR8901 [Common] Fix the bug -PR8901 Dec 12, 2024
@singiamtel
Copy link
Contributor

@vkucera is this okay to merge? CI is currently broken otherwise

CC @ktf

@alibuild
Copy link
Collaborator

Error while checking build/O2Physics/o2 for 77e6d4b at 2024-12-12 14:28:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/8961-slc9_x86-64/0/Common/TableProducer/Converters/trackQA002Converter.cxx:21:17: error: 'TracksQA_002' is not a member of 'o2::aod'; did you mean 'TracksQA_001'?
/sw/SOURCES/O2Physics/8961-slc9_x86-64/0/Common/TableProducer/Converters/trackQA002Converter.cxx:21:29: error: template argument 1 is invalid
/sw/SOURCES/O2Physics/8961-slc9_x86-64/0/Common/TableProducer/Converters/trackQA002Converter.cxx:26:19: error: expression cannot be used as a function
/sw/SOURCES/O2Physics/8961-slc9_x86-64/0/Common/TableProducer/Converters/trackQA002Converter.cxx:60:19: error: expression cannot be used as a function
ninja: build stopped: subcommand failed.

Full log here.

@vkucera
Copy link
Collaborator

vkucera commented Dec 12, 2024

@vkucera is this okay to merge? CI is currently broken otherwise

CC @ktf

Yes, I confirm this fixes the O2Physics compilation.
Although this is independent from the reported compilation error which is due to not using the latest O2.

@ddobrigk ddobrigk enabled auto-merge (squash) December 12, 2024 14:22
@pzhristov
Copy link
Contributor

I will merge it as soon as my local test is OK.

@ddobrigk ddobrigk disabled auto-merge December 12, 2024 15:13
@ddobrigk
Copy link
Collaborator

disabling auto-merge - the fastest way to fix the problem is to revert the original PR and force-merge the revert immediately ...

@ddobrigk
Copy link
Collaborator

reversal here #8964

@pzhristov pzhristov merged commit 4ae9f70 into AliceO2Group:master Dec 12, 2024
12 of 16 checks passed
@pzhristov
Copy link
Contributor

It compiles, so I merged it and the CI should be fine

hernasab pushed a commit to hernasab/O2Physics that referenced this pull request Dec 20, 2024
Co-authored-by: miranov25 <marian.ivanov@cern.cg>
feisenhu pushed a commit to feisenhu/O2Physics that referenced this pull request Jan 8, 2025
Co-authored-by: miranov25 <marian.ivanov@cern.cg>
smaff92 pushed a commit to smaff92/O2Physics that referenced this pull request Feb 17, 2025
Co-authored-by: miranov25 <marian.ivanov@cern.cg>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

6 participants