Wrapped Proxy Perf Improvements #58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dajinchu
commented
Jan 13, 2026
| // Why not pipe? Because Vike gives us `pipe` which sends data into a Writable, but Fastify's reply.send only accepts a ReadableStream. Passthrough can convert but causes race conditions | ||
| // We would have to pipe into reply.raw, but that skips Fastify's reply handling (like onSend hooks) | ||
| // Photon/universal-middleware solves this with some hacks around reply.body | ||
| .send(await getBody()) |
Collaborator
Author
There was a problem hiding this comment.
this was needed because we were getting "write to stream after end" issues with the streaming. it also seems to improve response time
dajinchu
commented
Jan 13, 2026
| if (pageContext._wrappedServerOnly) { | ||
| return await vikeReactRender(pageContext); | ||
| } | ||
| return { documentHtml: emptydocument }; |
Collaborator
Author
There was a problem hiding this comment.
in wrapped mode we render twice. once for routing, then again after we get data from rails. this adds fast-path for the initial routing render.
maybe in the future vike could give us an API for routing w/o rendering
reinabo
approved these changes
Jan 14, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
locally this brings wrapped proxy from ~200 req/s to 500.
Against AlignableWeb, we get
/sitemapfrom 20 req/s to ~40 (rails itself can only do 50 on direct requests)