Fix race condition when notifying workers of new tasks #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a race condition when we notify workers of new tasks, where `m_checkNextTask` would be cleared before we took a task item, which would cause a subsequent `notifyWorker` call on the same worker to return true while the worker was currently processing a task, causing `notifyOneWorker` to attempt to "wake up" a worker that was already processing a task, rather than notify another worker that was sitting idle. In addition: - Simplify the logic by using the mutex and regular booleans instead of relying on atomics - Release the locks before signaling the condition variables, to reduce lock contention from the woken-up thread
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a race condition when we notify workers of new tasks, where
m_checkNextTaskwould be cleared before we took a task item, which would cause a subsequentnotifyWorkercall on the same worker to return true while the worker was currently processing a task, causingnotifyOneWorkerto attempt to "wake up" a worker that was already processing a task, rather than notify another worker that was sitting idle.In addition: