Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refs #317. Partial, non-closing repository-readiness contribution. Draft for hosted validation and independent review.
Source base:
0b1ad59da398e3dbd6a696d0264bcb6ebd620219(main).Branch:
codex/ai-readiness-improvements->main.Scope: validation/CI/security configuration, contributor guidance and evidence. No application behavior, schema migration, provider SDK/runtime or ECorp execution authority is changed.
Harness first: use native Node test discovery, Cargo, pnpm, GitHub Actions/Dependabot/default CodeQL, and existing repository commands. The small driver adds source-bound receipts and a consistent entry point; it is not an agent scheduler, approval system or autonomous repair engine.
Coordination and remaining #317 scope
.github/skills/is included in native test discovery, with a regression; the unmerged review policy itself is not imported or approved here.ci.ymlintegration with test(factory): cover budget recovery and missing checkpoint proof #237. Preserve its ownership-verified fixtures, Linux process tests, Windows external-adapter job and native opt-in controls when resolving overlaps.Type of change
How Has This Been Tested?
The retained full local gate before publication follow-up passed 1035 Node tests, 554 Rust tests, zero failures; 343 Rust tests were explicitly ignored, not counted as passes. Migration, docs, formatting, Clippy, web build and web lint passed with no source change during that invocation.
Publication follow-up adds a review-skill discovery regression and removes the duplicate CodeQL job:
Reproduce from a trusted isolated worktree:
The host's npmjs.org TLS/registry-identity issue remains explicit in
docs/AI_READINESS.md; installed-dependency checks are not clean-bootstrap proof. TLS and supply-chain policies were not disabled. All existing dependency versions are retained; the previously undeclaredws@8.18.3test dependency is the only root dependency addition.Test Configuration:
Benchmark interpretation
The local development sequence was 54.2 -> 60.0 -> 67.1 -> 67.1, with final pre-publication foundations 87.0 and operations 51.75. These are historical local dirty-tree assessments with preserved run identities, not a new benchmark of this published commit. Both axes must reach 80 for AI-Ready; that verdict remains no. The CodeQL publication correction and any future native settings changes require fresh measurement before a new score claim.
Details:
docs/AI_READINESS.md,docs/VALIDATION.md,docs/reports/ai-readiness-validation-iteration-*.json, anddocs/reports/github-readiness-review-2026-09-18.md.Checklist
Repository settings were applied only after the separate exact-preview approval; the verified follow-up is recorded below. No merge, auto-merge, deployment, live credential rotation or policy bypass is authorized by this PR.
Hosted publication checkpoint
At published head
6119296d475e94a45b643534a3a0bbd581b130f2, the new hosted secret scan passed. Native CodeQL Actions/JavaScript/Python checks, all three runner-platform jobs, and the Windows desktop job passed at inspection; Rust analysis and integration were still running.The hosted
qualityjob failed after the newly enrolled Node suite: 939 passed, 62 failed, 5 skipped, 0 cancelled. All 62 failures point totools/e2e_checkpoint_verification.test.mjswithunsafe_posix_path: its Windows-shaped offline fixtures reachexpectedWorkspaceusing the Linux host's default path implementation. This is different from the intermittent local Teams timeout. Exact failing job.This original-head failure prompted the approved fixture/driver path-semantics repair recorded below. No suite was skipped, unsafe path accepted or gate waived. The generated failed validation receipt remains retained. The PR remains draft pending exact-head hosted validation and independent review.
Approved follow-up at
944dcbePublished head:
944dcbe1c95c7fece0cc57fb29bc3f90c371f31d.path.win32/path.posix. Native execution retains its host default; containment helpers, authority checks and live runtime configuration are unchanged.6119296driver and pass with the repair.pnpm check: all eight gates passed, 1054 Node passed, 554 Rust passed, 343 Rust ignored, no source change during validation and no unexecuted gates. Migration count: 41. Formatting, Clippy, docs, web build and web lint passed.secretsjob is not yet a main-wide required check.Follow-up evidence and unaltered full validation receipt retain exact source fingerprints. The final summary paragraph/receipt were reporting-only additions after validation; the validated code/test files were unchanged.
New exact-head hosted CI is running; it is not yet claimed green. Independent review is still required. No benchmark was rerun, so no new readiness score is claimed.
Enabling dependency alerts surfaced Dependabot alert #1, a moderate
glibadvisory in the desktop Cargo lockfile. Dependency compatibility/remediation is a separate follow-up; this scoped repair does not silently upgrade desktop dependencies.