Skip to content

Antalya 25.8 Backport of #91853 - Fix logical error with join_use_nulls and cross join - #2190

Merged
mkmkme merged 4 commits into
antalya-25.8from
backports/antalya-25.8/91853
Aug 14, 2026
Merged

mkmkme merged 4 commits into
antalya-25.8from
backports/antalya-25.8/91853

Conversation

@mkmkme

@mkmkme mkmkme commented Aug 8, 2026

Copy link
Copy Markdown
Collaborator

Fix logical error with join_use_nulls and cross join

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fix logical error with join_use_nulls and multiple joins along with cross join (ClickHouse#91853 by @vdimir)

CI/CD Options

Exclude tests:

  • Fast test
  • Integration Tests
  • Stateless tests
  • Stateful tests
  • Performance tests
  • Aarch64 tests
  • All with ASAN
  • All with TSAN
  • All with MSAN
  • All with UBSAN
  • All with Coverage
  • All Regression
  • Disable CI Cache

Regression jobs to run:

  • Fast suites (mostly <1h)
  • Aggregate Functions (2h)
  • Alter (1.5h)
  • Benchmark (30m)
  • ClickHouse Keeper (1h)
  • Iceberg (2h)
  • LDAP (1h)
  • OAuth (5m)
  • Parquet (1.5h)
  • RBAC (1.5h)
  • SSL Server (1h)
  • S3 (2h)
  • S3 Export (2h)
  • Swarms (30m)
  • Tiered Storage (2h)

…6_unexpected_return_type

Fix logical error with join_use_nulls and cross join
@mkmkme mkmkme added antalya backport Backport antalya-25.8 25.8 25.8 Altinity Stable labels Aug 8, 2026
@github-actions

github-actions Bot commented Aug 8, 2026 •

Copy link
Copy Markdown

Workflow [PR], commit [93b0458]

@mkmkme

mkmkme commented Aug 8, 2026

Copy link
Copy Markdown
Collaborator Author

The attached test failed on clean antalya-25.8 and passed with changes in the PR. Will verify when CI finishes

@mkmkme mkmkme added the verified Approved for release label Aug 14, 2026
@mkmkme
mkmkme merged commit d652a49 into antalya-25.8 Aug 14, 2026
180 of 192 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants