Conversation
Signed-off-by: Konstantin Morozov <just.morozov.k@gmail.com>
|
Workflow [PR], commit [37417b6b] |
Signed-off-by: Konstantin Morozov <just.morozov.k@gmail.com>
k-morozov
changed the title
Author
|
Another PR |
filimonov
added a commit
that referenced
this pull request
Sep 4, 2026
Three adjudications from review: keys stay "sufficiently full" semantic words (exact full member names rejected); the cut ships as a generation RESET (`G_BUILD` -> 1, baseline change points, retired-field sentinels and legacy generation tests deleted) since no installations exist; and C++ members follow an asymmetric rule - never more cryptic than the wire key, fuller where the wire is budget-compressed. Also folds in the review findings on revision 1: corrected descriptor math (213/224 today, 228/239 after the rename, 1 spare byte at the 240 floor, 17 `ref` bytes at 256, worst case derived from the `ProvenanceOp` table), the complete `op` inventory, `hold_reason` instead of `hold`, `key_generation` for `blob_run` rows, `condemn_round` unified across `cas_blob_meta` and `cas_run`, `pid` sanctioned as an established fragment, and a closed-value-sets section. Related: #2288 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
filimonov
added a commit
that referenced
this pull request
Sep 4, 2026
Review of revision 2 (5cc34ca) found four substantive defects, all fixed: - the `pl`/`rte`/`rts` sentinels are RETAINED, reclassified from compatibility scaffolding to permanently forbidden known-field guards: without them a tolerant reader would silently drop a persisted payload or accept removed terminal semantics from a malformed or hand-edited current-generation object; - the pool gates keep their own post-reset tests: `v:1` + `min_reader_generation:2` -> UNKNOWN_FORMAT_VERSION (the separate `decodePoolMeta` check the `v:2` test cannot cover), `v:0` via the dormant backward gate, and a fresh pool minting `min_reader_generation:1`; only generation-3-10 fixtures are deleted; - the member rule stays absolute: `RunRef::generation` is renamed `key_generation` (the wire key out-explained the member), resolving the contradiction with "no member renames required"; - the closed value sets are completed (`cas_blob_meta` state, snapshot/ catalog/fold-seal record kinds, the 17 registry type strings). Also: the `ProvenanceOp` wire words must move from two switches into one constexpr table shared by encoder, decoder, and the boundary test (the floor slack is one byte), and PR #2288 is described as rejected for this design rather than rejected outright (it remains an open draft). Related: #2288 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Store full-length keys in JSON CAS metadata objects instead of abbreviated ones
Documentation entry for user-facing changes
...
CI/CD Options
Exclude tests:
Regression jobs to run: